[#8132] Update actions and pages which set "noindex", "nofollow" crawler directives #8223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract out into a common concern included in `ApplicationController` so this hook/helper is available to all controllers.
Don't allow indexing of: - New citation page - New request page - Similar requests page - Request details page - User profile wall
These actions require a user to be logged in or link to actions which we don't allow to be indexed and as such there is no reason for search indexers to follow them.
Even though we're setting the response header ensure we set a consistent value in the meta tag.
Pages after the first shouldn't be crawled, this will help with site performance.
garethrees
reviewed
Apr 30, 2024
There was a problem hiding this comment.
Worth making the dependency on RobotsHeaders explicit in the concerns that use it:
module ProminenceHeaders
extend ActiveSupport::Concern
+ include RobotsHeaders
module PublicTokenable
extend ActiveSupport::Concern
+ include RobotsHeadershttps://api.rubyonrails.org/classes/ActiveSupport/Concern.html says you can do this (in the intro section of the documentation)
|
Reassigning as discussed to make a few tweaks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes #8132
What does this do?
Update actions and pages which set "noindex", "nofollow" crawler directives
Why was this needed?
Implementation notes
@garethrees are you happy with changing the number of paginated pages which are indexed? I'm concerned this might impact search ranking due to newer request pages not being indexed at all.